Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: require changeset on pull request #552

Merged
merged 11 commits into from
Jan 2, 2025
Merged

ci: require changeset on pull request #552

merged 11 commits into from
Jan 2, 2025

Conversation

orionmiz
Copy link
Member

@orionmiz orionmiz commented Dec 26, 2024

Adding the changeset is now mandatory for Pull Requests.

Use changeset add --empty if you want to avoid versioning.

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Jan 2, 2025 9:53am

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: eec641a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to separate it from the type-check job. How about creating a new job called changeset?

# as-is
jobs:
  type-check:
    # do typescript type check and changeset ci

# to-be
jobs:
  type-check:
    # do only typescript type check
  changeset:
    # do only changeset ci

@orionmiz
Copy link
Member Author

orionmiz commented Jan 1, 2025

I think it would be better to separate it from the type-check job. How about creating a new job called changeset?

# as-is
jobs:
  type-check:
    # do typescript type check and changeset ci

# to-be
jobs:
  type-check:
    # do only typescript type check
  changeset:
    # do only changeset ci

That's right. but this might be creating a lot of duplicated steps that are hard to maintain.

Let's move on after #553 merged.

Note: I considered composite action containing shared steps(setup node, cache, yarn install) but post-if for conditional cache save is not supported yet.

This reverts commit 169473a.
@orionmiz orionmiz merged commit f526ff7 into main Jan 2, 2025
5 checks passed
@orionmiz orionmiz deleted the changeset-mandatory branch January 2, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants