-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: require changeset on pull request #552
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to separate it from the type-check
job. How about creating a new job called changeset
?
# as-is
jobs:
type-check:
# do typescript type check and changeset ci
# to-be
jobs:
type-check:
# do only typescript type check
changeset:
# do only changeset ci
That's right. but this might be creating a lot of duplicated steps that are hard to maintain. Let's move on after #553 merged. Note: I considered composite action containing shared steps(setup node, cache, yarn install) but post-if for conditional cache save is not supported yet. |
466af30
to
ae59457
Compare
This reverts commit 169473a.
Adding the changeset is now mandatory for Pull Requests.
Use
changeset add --empty
if you want to avoid versioning.