fix(config): correct the truncation of process name(comm name) #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously dae truncate the process names in pname configs to 16 bytes Now we truncate the name to 15 bytes because the length of the comm name of processes in linux is 15 bytes. This makes `pname(systemd-resolved)` works the same as `pname(systemd-resolve)` Closes daeuniverse#736, daeuniverse#474
|
@xcpky 为什么合并到 develop，请发起一个到main的pr，谢谢！ |
为啥规则这里这么写呢，请您解释下，我当时还觉得奇怪。 我明天发main的pr |
|
@xcpky 可能是失误，后面会更正，请麻烦提到 main 吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#736
Checklist
Full Changelogs
Issue Reference
#736
#474
Closes #[736]
Test Result
add pname(systemd-resolved) -> must_direct
then all the dns traffic through systemd-resolved goes out directly
but before the PR, it doesn't.
I test the patch on main branch, because on develop branch dae errors out without this patch as