Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tab closing when process exists & app closes when no more tabs #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SelfMadeSystem
Copy link

@SelfMadeSystem SelfMadeSystem commented Mar 5, 2022

Description

  • Added tab closing when process exists
  • Added app closing when no more tabs open

Type of change

Please tick the relevant option by putting an X inside the bracket

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

(Bit of both I guess)

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas; tf none of your code is commented. Easy to read anyways.
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • All current GitHub actions pass
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have read the CONTRIBUTING document

@nmcain
Copy link
Member

nmcain commented Mar 19, 2022

I'm not sure if this would work well with the embdedded view inside pangolin. Can someone test this?

@SelfMadeSystem
Copy link
Author

Did someone test this yet?

@larsb24
Copy link
Member

larsb24 commented Nov 11, 2024

@SelfMadeSystem

Did someone test this yet?

Hi, I just pushed a fix for the whole tab situation as the whole app was broken due to dependency changes etc.
If you're fine with it, you could maybe try to fix the conflicts for the PR or I try to copy your changes, since we need to do some refactoring for this repo either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants