Merge pull request #60 from sonatard/numeric

Fix NUMERIC NOT NULL
daichirata · Jun 18, 2024 · fb333c3 · fb333c3
2 parents 7cc6a2c + 2b1a21c
commit fb333c3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/internal/hammer/diff.go b/internal/hammer/diff.go
@@ -676,6 +676,8 @@ func (g *Generator) setDefault(col spansql.ColumnDef) spansql.ColumnDef {
 		col.Default = spansql.IntegerLiteral(0)
 	case spansql.Float64:
 		col.Default = spansql.FloatLiteral(0)
+	case spansql.Numeric:
+		col.Default = spansql.FloatLiteral(0)
 	case spansql.String:
 		col.Default = spansql.StringLiteral("")
 	case spansql.Bytes:

diff --git a/internal/hammer/diff_test.go b/internal/hammer/diff_test.go
@@ -119,6 +119,7 @@ CREATE TABLE t1 (
   t1_8 TIMESTAMP NOT NULL,
   t1_9 JSON NOT NULL,
   t1_10 ARRAY<INT64> NOT NULL,
+  t1_11 NUMERIC NOT NULL,
 ) PRIMARY KEY(t1_1);
 `,
 			expected: []string{
@@ -140,6 +141,8 @@ CREATE TABLE t1 (
 				`ALTER TABLE t1 ALTER COLUMN t1_9 DROP DEFAULT`,
 				`ALTER TABLE t1 ADD COLUMN t1_10 ARRAY<INT64> NOT NULL DEFAULT ([])`,
 				`ALTER TABLE t1 ALTER COLUMN t1_10 DROP DEFAULT`,
+				`ALTER TABLE t1 ADD COLUMN t1_11 NUMERIC NOT NULL DEFAULT (0)`,
+				`ALTER TABLE t1 ALTER COLUMN t1_11 DROP DEFAULT`,
 			},
 		},
 		{
@@ -161,6 +164,7 @@ CREATE TABLE t1 (
   t1_8 TIMESTAMP DEFAULT (TIMESTAMP '2022-06-18 04:36:00.000000+09:00'),
   t1_9 JSON DEFAULT (JSON '{"key": "value"}'),
   t1_10 ARRAY<INT64> DEFAULT ([1]),
+  t1_11 NUMERIC DEFAULT (11),
 ) PRIMARY KEY(t1_1);
 `,
 			expected: []string{
@@ -173,6 +177,7 @@ CREATE TABLE t1 (
 				`ALTER TABLE t1 ADD COLUMN t1_8 TIMESTAMP DEFAULT (TIMESTAMP '2022-06-18 04:36:00.000000+09:00')`,
 				`ALTER TABLE t1 ADD COLUMN t1_9 JSON DEFAULT (JSON '{"key": "value"}')`,
 				`ALTER TABLE t1 ADD COLUMN t1_10 ARRAY<INT64> DEFAULT ([1])`,
+				`ALTER TABLE t1 ADD COLUMN t1_11 NUMERIC DEFAULT (11)`,
 			},
 		},
 		{
@@ -194,6 +199,7 @@ CREATE TABLE t1 (
   t1_8 TIMESTAMP NOT NULL DEFAULT (TIMESTAMP '2022-06-18 04:36:00.000000+09:00'),
   t1_9 JSON NOT NULL DEFAULT (JSON '{"key": "value"}'),
   t1_10 ARRAY<INT64> NOT NULL DEFAULT ([1]),
+  t1_11 NUMERIC NOT NULL DEFAULT (11),
 ) PRIMARY KEY(t1_1);
 `,
 			expected: []string{
@@ -206,6 +212,7 @@ CREATE TABLE t1 (
 				`ALTER TABLE t1 ADD COLUMN t1_8 TIMESTAMP NOT NULL DEFAULT (TIMESTAMP '2022-06-18 04:36:00.000000+09:00')`,
 				`ALTER TABLE t1 ADD COLUMN t1_9 JSON NOT NULL DEFAULT (JSON '{"key": "value"}')`,
 				`ALTER TABLE t1 ADD COLUMN t1_10 ARRAY<INT64> NOT NULL DEFAULT ([1])`,
+				`ALTER TABLE t1 ADD COLUMN t1_11 NUMERIC NOT NULL DEFAULT (11)`,
 			},
 		},
 		{