Dependency fix #691
Merged
Dependency fix #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dqd great idea, thanks! |
Sanster
added a commit
to Sanster/IOPaint
that referenced
this pull request
Nov 23, 2024
heftig
referenced
this pull request
in mcmonkeyprojects/SwarmUI
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Daniel. First of all, thanks for this awesome package, the results look really great.
However, after installing
rembg, I noticed that performance of my environment decreased rapidly. It was caused by having a hard dependency ononnxruntime. Even when installing therembg[gpu]variant, it messed myonnxruntime-gpuinstallation.I could not find a better solution than provide
rembg[cpu], which would installonnxruntimeexplicitly. What do you think?