Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use organizational and repository variables #15557

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Use organizational and repository variables #15557

merged 5 commits into from
Dec 4, 2024

Conversation

brianjmurrell
Copy link
Contributor

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell brianjmurrell self-assigned this Dec 3, 2024
@brianjmurrell
Use organizational and repository variables
a83bf48 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true

#Pragmas from previous commit message:
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell
Fix
6c38bd1 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true


#Pragmas from previous commit message:
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell
Strings are not cast to boolean, sadly
506621e 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true


#Pragmas from previous commit message:
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell
Move up to workflow env. context
d3d0db9 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true


#Pragmas from previous commit message:
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes
Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell
Fix variable names
ee05833 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true

Signed-off-by: Brian J. Murrell <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Use

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Functional on EL 8.8 Test Results

 3 tests  ±0   3 ✅ ±0   29s ⏱️ ±0s
11 suites ±0   0 💤 ±0 
11 files   ±0   0 ❌ ±0 

Results for commit ee05833. ± Comparison against base commit 8bbabf7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Functional Hardware Medium Test Results

28 tests  ±0   28 ✅ ±0   19s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit ee05833. ± Comparison against base commit 8bbabf7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Functional Hardware Large Test Results

52 tests  ±0   52 ✅ ±0   19s ⏱️ -1s
11 suites ±0    0 💤 ±0 
11 files   ±0    0 ❌ ±0 

Results for commit ee05833. ± Comparison against base commit 8bbabf7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Functional Hardware Medium Verbs Provider Test Results

28 tests  ±0   28 ✅ ±0   17s ⏱️ -13s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit ee05833. ± Comparison against base commit 8bbabf7.

♻️ This comment has been updated with latest results.

@brianjmurrell brianjmurrell marked this pull request as ready for review December 4, 2024 05:47
@brianjmurrell brianjmurrell merged commit ea61c01 into bmurrell/gha-refactor Dec 4, 2024
72 of 75 checks passed
@brianjmurrell brianjmurrell deleted the bmurrell/gha-org-vars branch December 4, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brianjmurrell brianjmurrell

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brianjmurrell