Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16914 vos: don't print error message on ITER_EXIT #15675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NiuYawei
Copy link
Contributor

@NiuYawei NiuYawei commented Jan 2, 2025

Don't print error message on ITER_EXIT in vos_obj_iterate().

Signed-off-by: Niu Yawei [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@NiuYawei NiuYawei requested review from a team as code owners January 2, 2025 13:17
Copy link

github-actions bot commented Jan 2, 2025

Ticket title is 'typo in vos_iterate_internal()'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16914

sherintg
sherintg previously approved these changes Jan 2, 2025
@daltonbohning
Copy link
Contributor

Copyright GHA failing implies the githooks are not configured. It probably shouldn't be an Intel copyright anymore, but either way you should configure the githooks since the lint checks are required.
\https://github.com/daos-stack/daos/tree/master/utils/githooks#readme

@NiuYawei
Copy link
Contributor Author

NiuYawei commented Jan 3, 2025

Copyright GHA failing implies the githooks are not configured. It probably shouldn't be an Intel copyright anymore, but either way you should configure the githooks since the lint checks are required. \https://github.com/daos-stack/daos/tree/master/utils/githooks#readme

yeah, I forgot to configure githooks on my HPE laptop.

@NiuYawei NiuYawei requested a review from sherintg January 3, 2025 01:22
sherintg
sherintg previously approved these changes Jan 3, 2025
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15675/2/execution/node/1484/log

jolivier23
jolivier23 previously approved these changes Jan 4, 2025
@NiuYawei NiuYawei dismissed stale reviews from jolivier23 and sherintg via ffcb535 January 6, 2025 01:04
@NiuYawei
Copy link
Contributor Author

NiuYawei commented Jan 6, 2025

Fixed copyright

sherintg
sherintg previously approved these changes Jan 6, 2025
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15675/3/execution/node/1464/log

Don't print error message on ITER_EXIT in vos_obj_iterate().

Signed-off-by: Niu Yawei <[email protected]>
@NiuYawei NiuYawei changed the title DAOS-16914 vos: fix typo in vos_iterate_internal() DAOS-16914 vos: don't print error message on ITER_EXIT Jan 7, 2025
@NiuYawei NiuYawei requested a review from sherintg January 7, 2025 03:35
@NiuYawei
Copy link
Contributor Author

NiuYawei commented Jan 7, 2025

@sherintg , @jolivier23 Sorry, I realized that we don't return 0 for ITER_EXIT for some reason, updated patch.

@daltonbohning
Copy link
Contributor

I restarted the Jenkins pipeline due to pipeline-lib bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants