Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-623 build: Minor build fix #15749

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

DAOS-623 build: Minor build fix #15749

wants to merge 10 commits into from

Conversation

jolivier23
Copy link
Contributor

@jolivier23 jolivier23 commented Jan 20, 2025 •
edited
Loading

Use pkgconfig file for fused
Use self.lib_path for path search.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jolivier23
DAOS-623 build: Update developer package for fused
9a939ba 
We are using v1.0.0 for rpm, just sync the build.config.
There is no functional difference here between them.

Skip-func-test: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
DAOS-623 build: Minor build fix
320d5c6 
Use pkgconfig file for fused
Use self.lib_path for path search

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 requested review from a team as code owners January 20, 2025 04:44
@github-actions GitHub Actions
Copy link

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6.3'
https://daosio.atlassian.net/browse/DAOS-623

@jolivier23
Fix spellcheck error
91d41a8 
Signed-off-by: Jeff Olivier <[email protected]>
Base automatically changed from jvolivie/bump_version to master January 21, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jolivier23