Always log stack traces for Error objects #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #3585 The default logging omits stack traces by default and prints them only in verbose mode. This is intended to allow builder implementations to cease execution and log a user friendly message by throwing a single `Exception` with a custom `toString()`. When a builder or utility library has an implementation bug leading to an `Error` the stack trace is much more likely to be useful information for debugging, and worth including by default.
jakemac53
approved these changes
Sep 28, 2023
|
I'm going to wait until we have agreement and I can land dart-lang/source_gen#687 before landing this. Ideally I'd like to have |
|
Unblocked? |
|
We haven't published |
|
Hmm, do we have a good way to ignore the markdown link check for a (hopefully transient) external problem? Or should I merge on red? |
merge on red!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3585
The default logging omits stack traces by default and prints them only
in verbose mode. This is intended to allow builder implementations to
cease execution and log a user friendly message by throwing a single
Exceptionwith a customtoString(). When a builder or utilitylibrary has an implementation bug leading to an
Errorthe stack traceis much more likely to be useful information for debugging, and worth
including by default.