Bump dart_flutter_team lints to latest across packages #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate lints in files
PR HealthBreaking changes ✔️
Coverage
|
| File | Coverage |
|---|---|
| pkgs/bazel_worker/benchmark/benchmark.dart | 💔 Not covered |
| pkgs/bazel_worker/e2e_test/bin/async_worker_in_isolate.dart | 💔 Not covered |
| pkgs/bazel_worker/e2e_test/lib/async_worker.dart | 💔 Not covered |
| pkgs/bazel_worker/e2e_test/lib/forwards_to_isolate_async_worker.dart | 💔 Not covered |
| pkgs/bazel_worker/e2e_test/test/e2e_test.dart | 💔 Not covered |
| pkgs/bazel_worker/example/client.dart | 💔 Not covered |
| pkgs/bazel_worker/lib/src/async_message_grouper.dart | 💚 98 % ⬆️ 0 % |
| pkgs/bazel_worker/lib/src/driver/driver.dart | 💚 89 % ⬆️ 0 % |
| pkgs/bazel_worker/lib/src/driver/driver_connection.dart | 💚 75 % ⬆️ 1 % |
| pkgs/bazel_worker/lib/src/utils.dart | 💚 100 % |
| pkgs/bazel_worker/lib/src/worker/async_worker_loop.dart | 💚 93 % ⬆️ 1 % |
| pkgs/bazel_worker/lib/src/worker/sync_worker_loop.dart | 💚 93 % ⬆️ 1 % |
| pkgs/bazel_worker/lib/src/worker/worker_connection.dart | 💚 47 % |
| pkgs/bazel_worker/lib/testing.dart | 💚 86 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|
License Headers ⚠️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| pkgs/bazel_worker/benchmark/benchmark.dart |
| pkgs/bazel_worker/example/client.dart |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/bazel_worker/example/worker.dart |
| pkgs/bazel_worker/lib/src/worker_protocol.pb.dart |
| pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart |
| pkgs/boolean_selector/example/example.dart |
| pkgs/clock/lib/clock.dart |
| pkgs/clock/lib/src/clock.dart |
| pkgs/clock/lib/src/default.dart |
| pkgs/clock/lib/src/stopwatch.dart |
| pkgs/clock/lib/src/utils.dart |
| pkgs/clock/test/clock_test.dart |
| pkgs/clock/test/default_test.dart |
| pkgs/clock/test/stopwatch_test.dart |
| pkgs/clock/test/utils.dart |
| pkgs/html/example/main.dart |
| pkgs/html/lib/dom.dart |
| pkgs/html/lib/dom_parsing.dart |
| pkgs/html/lib/html_escape.dart |
| pkgs/html/lib/parser.dart |
| pkgs/html/lib/src/constants.dart |
| pkgs/html/lib/src/encoding_parser.dart |
| pkgs/html/lib/src/html_input_stream.dart |
| pkgs/html/lib/src/list_proxy.dart |
| pkgs/html/lib/src/query_selector.dart |
| pkgs/html/lib/src/token.dart |
| pkgs/html/lib/src/tokenizer.dart |
| pkgs/html/lib/src/treebuilder.dart |
| pkgs/html/lib/src/utils.dart |
| pkgs/html/test/dom_test.dart |
| pkgs/html/test/parser_feature_test.dart |
| pkgs/html/test/parser_test.dart |
| pkgs/html/test/query_selector_test.dart |
| pkgs/html/test/selectors/level1_baseline_test.dart |
| pkgs/html/test/selectors/level1_lib.dart |
| pkgs/html/test/selectors/selectors.dart |
| pkgs/html/test/support.dart |
| pkgs/html/test/tokenizer_test.dart |
This check can be disabled by tagging the PR with skip-license-check.
natebosch
approved these changes
Dec 13, 2024
|
The failure here confuses the heck out of me... |
kevmoo
force-pushed
the
cleanup_silly
branch
from
3c48a6b to
3df98f8
Compare
github-actions
bot
added
the
type-infra
|
This is the argument for using mono_repo for CI. Keeping track of the scripts and making them consistent is tricky... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate lints in files