DCM workflow no longer needs the run-dcm-workflow label (#2283)

dart-lang · Nov 8, 2023 · 148aaaa · 148aaaa
1 parent 927c70e
commit 148aaaa
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 29 deletions.
diff --git a/.github/workflows/dcm.yml b/.github/workflows/dcm.yml
@@ -3,16 +3,13 @@
 name: Dart Code Metrics
 
 on:
-  pull_request_target:
-    # labeled and unlabeled are required along with open to re-run
-    # workflow when the run-dcm-workflow label is added or removed.
-    types: [opened, labeled, unlabeled]
+  pull_request:
+    types: [synchronize, opened, reopened]
     branches:
       - master
 
 jobs:
   dcm:
-    if: contains(github.event.pull_request.labels.*.name, 'run-dcm-workflow')
     name: Dart Code Metrics
     runs-on: ubuntu-latest
     steps:
@@ -39,5 +36,5 @@ jobs:
         if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: dwds
       - name: Run DCM on DWDS
-        run: dcm analyze --ci-key="${{ secrets.DCM_CI_KEY }}" --email="${{ secrets.DCM_EMAIL }}" lib
+        run: dcm analyze lib
         working-directory: dwds
diff --git a/.github/workflows/dcm_label.yml b/.github/workflows/dcm_label.yml
diff --git a/dwds/lib/src/debugging/inspector.dart b/dwds/lib/src/debugging/inspector.dart
@@ -366,7 +366,7 @@ class AppInspector implements AppInspectorInterface {
   Future<RemoteObject> callFunction(
     String function,
     Iterable<String> argumentIds,
-  ) async {
+  ) {
     final arguments = argumentIds.map(remoteObjectFor).toList();
     return _jsCallFunction(function, arguments);
   }

diff --git a/dwds/lib/src/loaders/strategy.dart b/dwds/lib/src/loaders/strategy.dart
@@ -131,9 +131,12 @@ abstract class LoadStrategy {
 
   /// Initializes a [MetadataProvider] for the application located at the
   /// provided [entrypoint].
-  Future<void> trackEntrypoint(String entrypoint) async {
+  Future<void> trackEntrypoint(String entrypoint) {
     final metadataProvider = MetadataProvider(entrypoint, _assetReader);
     _providers[metadataProvider.entrypoint] = metadataProvider;
+    // Returns a Future so that the asynchronous g3-implementation can override
+    // this method:
+    return Future.value();
   }
 }
 

diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart
@@ -392,7 +392,7 @@ class ChromeProxyService implements VmServiceInterface {
     String scriptId,
     int line, {
     int? column,
-  }) async {
+  }) {
     return wrapInErrorHandlerAsync(
       'addBreakpoint',
       () => _addBreakpoint(isolateId, scriptId, line),