Skip to content

Commit

Permalink
Add ignores for deprecated web libraries with a TODO and move dwds to…
Browse files Browse the repository at this point in the history
… 24.4.0-wip (#2559)

Dart web libraries are now deprecated. This triggers a lint which we fail on. We should migrate these to dart:js_interop and package:web, but for now, ignore to make CI happy.

This also moves the CHANGELOG, pubspec, and version.dart files to 24.4.0-wip, which is needed for proper_release_test to pass.
  • Loading branch information
srujzs authored Jan 7, 2025
1 parent e72f365 commit fcd906f
Show file tree
Hide file tree
Showing 23 changed files with 53 additions and 2 deletions.
2 changes: 2 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 24.4.0-wip

## 24.3.0

- Update to be forward compatible with changes to `package:shelf_web_socket`.
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/chrome_api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:js/js.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/cider_connection.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
library;

import 'dart:convert';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js_util';

import 'package:js/js.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/copier.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
@JS()
library;

// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:js/js.dart';
Expand Down
4 changes: 4 additions & 0 deletions dwds/debug_extension/web/debug_info.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
library;

import 'dart:convert';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js';

import 'package:dwds/data/debug_info.dart';
Expand Down
4 changes: 4 additions & 0 deletions dwds/debug_extension/web/detector.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
library;

import 'dart:convert';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js_util';

import 'package:dwds/data/debug_info.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/devtools.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
@JS()
library;

// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:dwds/data/debug_info.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/messaging.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ library;

import 'dart:async';
import 'dart:convert';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js_util';

import 'package:js/js.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/panel.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ library;

import 'dart:async';
import 'dart:convert';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:dwds/data/debug_info.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/popup.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ library;

import 'dart:async';
import 'dart:convert';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:dwds/data/debug_info.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/storage.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ library;

import 'dart:async';
import 'dart:convert';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js_util';

import 'package:js/js.dart';
Expand Down
2 changes: 2 additions & 0 deletions dwds/debug_extension/web/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
library;

import 'dart:async';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js_util';

import 'package:js/js.dart';
Expand Down
5 changes: 5 additions & 0 deletions dwds/debug_extension/web/web_api.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js_util' as js_util;

import 'package:js/js.dart';
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: dwds
# Every time this changes you need to run `dart run build_runner build`.
version: 24.3.0
version: 24.4.0-wip
description: >-
A service that proxies between the Chrome debug protocol and the Dart VM
service protocol.
Expand Down
2 changes: 2 additions & 0 deletions example/web/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import 'dart:async';
import 'dart:convert';
import 'dart:developer';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

void main() {
Expand Down
2 changes: 2 additions & 0 deletions fixtures/_experimentSound/web/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import 'dart:async';
import 'dart:core';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

void main() {
Expand Down
2 changes: 2 additions & 0 deletions fixtures/_testCircular2Sound/web/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import 'dart:async';
import 'dart:core';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:_test_circular1_sound/library1.dart';
Expand Down
2 changes: 2 additions & 0 deletions fixtures/_testHotRestart2Sound/web/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.

import 'dart:core';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:_test_hot_restart1/library1.dart';
Expand Down
2 changes: 2 additions & 0 deletions fixtures/_testPackageSound/web/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import 'dart:async';
import 'dart:convert';
import 'dart:core';
import 'dart:developer';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

import 'package:_test_package_sound/test_library.dart';
Expand Down
2 changes: 2 additions & 0 deletions fixtures/_testSound/example/append_body/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import 'dart:async';
import 'dart:developer';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

void main() {
Expand Down
4 changes: 4 additions & 0 deletions fixtures/_testSound/example/hello_world/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ import 'dart:async';
import 'dart:collection';
import 'dart:convert';
import 'dart:developer';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:js';

import 'package:intl/intl.dart';
Expand Down
2 changes: 2 additions & 0 deletions fixtures/_webdevSoundSmoke/web/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import 'dart:async';
import 'dart:convert';
import 'dart:developer';
// TODO: https://github.com/dart-lang/webdev/issues/2508
// ignore: deprecated_member_use
import 'dart:html';

void main() {
Expand Down

0 comments on commit fcd906f

Please sign in to comment.