Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll package:vm_service to 13.0.0 #2265

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Roll package:vm_service to 13.0.0 #2265

merged 2 commits into from
Oct 25, 2023

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Oct 25, 2023

No description provided.

@@ -1,4 +1,5 @@
## 22.1.0-wip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be stripped down to 22.1.0? same with pubspec version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will when it's time for an actual release. We can roll into the SDK with this as-is.

@@ -1,6 +1,7 @@
## 3.2.0-wip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.2.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -wip gets removed when we release webdev, so this is okay

Copy link
Contributor

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments about package versions, but lgtm

@bkonyi bkonyi merged commit 25f17cd into master Oct 25, 2023
55 of 56 checks passed
@bkonyi bkonyi deleted the vm_service_13.0.0 branch October 25, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants