Restructure LoadStrategy to provide build arguments #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 27, 2023 10:30
…ad-build-arguments
…ad-build-arguments
elliette
reviewed
Oct 30, 2023
elliette
reviewed
Oct 30, 2023
elliette
reviewed
Oct 30, 2023
…ad-build-arguments
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 1, 2023
Pins DWDS to dart-lang/webdev@5ad79c2 which is necessary to unblock Dwds rolls due to this change to the LoadStragegy interface: dart-lang/webdev#2270, which is a breaking change to google3. Towards: dart-lang/webdev#2276 Change-Id: I24fe79315b8493103c6b00e96f4fcea1ee011231 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333123 Reviewed-by: Nicholas Shahan <[email protected]> Commit-Queue: Anna Gringauze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure LoadStrategy to provide build arguments.
This change is the first step needed to support reading the build arguments from build metadata when they are not known before launching dwds (for example, when using blaze or build_web_compilers to build the app).
Towards: flutter/devtools#5350
Towards: #1290