Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename copied SDK directory prefix from 'sdk copy' to 'sdk_copy' #2557

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Jan 7, 2025

webdev/test/e2e_test.dart was failing due to paths with spaces not being handled correctly.

Related issue: #2556
Fixes dart-lang/sdk#59784

webdev/test/e2e_test.dart was failing due to paths with spaces not being
handled correctly.

Related issue: #2556
Fixes dart-lang/sdk#59784
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bkonyi

@bkonyi bkonyi merged commit 7dc5c3a into main Jan 9, 2025
49 checks passed
@bkonyi bkonyi deleted the sdk_copy_with_underscore branch January 9, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid vm isolate snapshot seen when running webdev e2e_test.dart on Windows
2 participants