Update to latest lints and fix problems #2578
Open
+902
−509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
commented
Jan 23, 2025
| !e.metaKey) { | ||
| e.preventDefault(); | ||
| launchDevToolsJs.callAsFunction(); | ||
| if (e.isA<KeyboardEvent>()) { |
There was a problem hiding this comment.
Is almost certainly was NOT working before. Or maybe just not in Wasm?
CC @srujzs
There was a problem hiding this comment.
@srujzs have we talk about an asA<T> functions that returns T?? (or similar)
There was a problem hiding this comment.
e is KeyboardEvent is always returning true regardless of platform because Event and KeyboardEvent have the same representation type, so this was broken. Nice catch!
re: asA, yes. dart-lang/sdk#56957 (comment)
There was a problem hiding this comment.
Latest lints catch these for us!
|
Since you modified |
srujzs
approved these changes
Jan 23, 2025
|
Removing myself since I no longer work on dwds :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.