add take(1) to pipe to ensure subscription will end

dasch-swiss · May 23, 2024 · b54ab72 · b54ab72
1 parent 53d513e
commit b54ab72
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/apps/dsp-app/src/app/workspace/resource/representation/upload/upload.component.ts b/apps/dsp-app/src/app/workspace/resource/representation/upload/upload.component.ts
@@ -21,7 +21,7 @@ import { NotificationService } from '@dasch-swiss/vre/shared/app-notification';
 import { UploadedFile, UploadFileService } from '@dasch-swiss/vre/shared/app-resource-properties';
 import { Store } from '@ngxs/store';
 import { ProjectsSelectors } from '@dasch-swiss/vre/shared/app-state';
-import { filter, map, mergeMap } from 'rxjs/operators';
+import { filter, map, mergeMap, take } from 'rxjs/operators';
 import { AppConfigService } from '@dasch-swiss/vre/shared/app-config';
 
 // https://stackoverflow.com/questions/45661010/dynamic-nested-reactive-form-expressionchangedafterithasbeencheckederror
@@ -99,6 +99,7 @@ export class UploadComponent implements OnInit {
 
         this._store.select(ProjectsSelectors.currentProject).pipe(
           filter(v => v !== undefined),
+          take(1),
           map(prj=> prj.shortcode),
           mergeMap(sc => this._upload.upload(this.file, sc))
         ).subscribe(

diff --git a/libs/vre/shared/app-resource-properties/src/lib/upload2.component.ts b/libs/vre/shared/app-resource-properties/src/lib/upload2.component.ts
@@ -8,7 +8,7 @@ import {fileValueMapping} from './file-value-mapping';
 import { UploadedFile, UploadFileService } from './upload-file.service';
 import {Store} from "@ngxs/store";
 import {ProjectsSelectors} from "@dasch-swiss/vre/shared/app-state";
-import {filter, map, mergeMap} from "rxjs/operators";
+import { filter, map, mergeMap, take } from 'rxjs/operators';
 
 @Component({
   selector: 'app-upload-2',
@@ -123,6 +123,7 @@ export class Upload2Component implements ControlValueAccessor {
   private _uploadFile(file: File): void {
     this._store.select(ProjectsSelectors.currentProject).pipe(
         filter(v => v !== undefined),
+        take(1),
         map(prj=> prj.shortcode),
         mergeMap(sc => this._upload.upload(file, sc))
     ).subscribe((res: UploadedFile) => {