Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use dsp-ingest for file upload (DEV-2628) #1602

Merged
merged 17 commits into from
May 24, 2024
Merged

refactor: Use dsp-ingest for file upload (DEV-2628) #1602

merged 17 commits into from
May 24, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented May 17, 2024 •
edited
Loading

  • add configuration for dsp-ingest server
  • upload binaries to dsp-ingest instead of Sipi

Needs dasch-swiss/dsp-js-lib#639 to be merged, released and integrated for updating dsp-api resources correctly.

For now I was able to test this locally by publish the dsp-js-lib for my machine using our built in yalc support:

> cd dsp-js-lib
> npm run yalc-publish

And import it into the app:

> cd dsp-das
> npm run yalc-add-lib

@seakayone seakayone force-pushed the feat/use-dsp-ingest-for-file-upload branch from 1525c55 to d7c5b15 Compare May 17, 2024 13:45
@seakayone seakayone changed the title feat/use dsp ingest for file upload refactor: Use dsp-ingest for file upload May 17, 2024
@seakayone seakayone self-assigned this May 17, 2024
@seakayone seakayone force-pushed the feat/use-dsp-ingest-for-file-upload branch 3 times, most recently from 649b3f8 to 43cd50f Compare May 21, 2024 13:33
@seakayone seakayone force-pushed the feat/use-dsp-ingest-for-file-upload branch from 43cd50f to 70ace42 Compare May 21, 2024 13:34
@seakayone seakayone changed the title refactor: Use dsp-ingest for file upload refactor: Use dsp-ingest for file upload (DEV-2628) May 21, 2024
@seakayone seakayone force-pushed the feat/use-dsp-ingest-for-file-upload branch from 097784f to 6b0a35d Compare May 23, 2024 10:59
@seakayone seakayone requested a review from irmastnt May 23, 2024 12:06
@seakayone seakayone marked this pull request as ready for review May 23, 2024 12:06
@seakayone seakayone merged commit e8ab798 into main May 24, 2024
13 checks passed
@seakayone seakayone deleted the feat/use-dsp-ingest-for-file-upload branch May 24, 2024 08:43
@daschbot daschbot mentioned this pull request May 24, 2024
Merged
irmastnt added a commit that referenced this pull request May 24, 2024
@irmastnt
Merge branch 'julien/compound' into feature/dev-3673-compound-object-…
455f1fd 
…loads-infinitely-if-one-of-its-images-is

* julien/compound:
  refactor: Use dsp-ingest for file upload (DEV-2628) (#1602)
irmastnt added a commit that referenced this pull request May 24, 2024
@irmastnt
Merge branch 'julien/compound' into feature/dev-3673-compound-object-…
2cd0ce3 
…loads-infinitely-if-one-of-its-images-is

* julien/compound:
  refactor: Use dsp-ingest for file upload (DEV-2628) (#1602)
irmastnt added a commit that referenced this pull request May 24, 2024
@irmastnt
Merge branch 'main' into feature/dev-3667-various-addedit-resource-pr…
229e190 
…operty-value-bugs

* main:
  refactor: separate compound and region views business logic (#1607)
  refactor: Use dsp-ingest for file upload (DEV-2628) (#1602)
  fix: Fix setting 'status' undefined error (#1605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derschnee68 derschnee68 derschnee68 approved these changes

@irmastnt irmastnt irmastnt approved these changes

@domsteinbach domsteinbach Awaiting requested review from domsteinbach

Assignees

@seakayone seakayone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @irmastnt @derschnee68