Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace
dask_ml.wrappers.Incremental
with customIncremental
class #855Replace
dask_ml.wrappers.Incremental
with customIncremental
class #855Changes from all commits
28771dc
4734d8a
dc49752
8d593b0
8268096
7c60bd3
95d6ec6
0f91006
09fc4a6
f0dc935
8356dd4
8fcb67c
ebe2348
aadc04d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could experimentClass be a gpu based model or is it limited to cpu based ones only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, since I think every example I've seen with
experiment_class
has been with a CPUdask_ml
model... I can try to get a better idea of the scope when the pytests in #886 are updated with other non-dask_ml
models. We can see about adding GPU tests there too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR , can you file an issue to clean up the
wrap_predict
andwrap_fit
arguments. I think we can get rid of this or do a better default based on the class name of the model.For
sklearn
andsingle gpu
cuML models, switch this to true else switch this to False.