e2e tests Oracle source #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmekumari
force-pushed
the
e2e-oraclesource_tests
branch
from
4b3d35e to
705cd0f
Compare
itsmekumari
force-pushed
the
e2e-oraclesource_tests
branch
from
705cd0f to
83d1c42
Compare
| Then Replace input plugin property: "port" with value: "port" for Credentials and Authorization related fields | ||
| Then Replace input plugin property: "user" with value: "username" for Credentials and Authorization related fields | ||
| Then Replace input plugin property: "password" with value: "password" for Credentials and Authorization related fields | ||
| Then Click plugin property: "switch-useConnection" |
There was a problem hiding this comment.
Here verifying the error message displayed on header as in-line error is already covered in mandatory fields use case.
Comment on lines
+424
to
+426
| @Before(order = 1, value = "@CONNECTION") | ||
| public static void setNewConnectionName() { | ||
| String connectionName = "Oracle" + RandomStringUtils.randomAlphanumeric(10); |
There was a problem hiding this comment.
This is a common class, we should take connectionPrefix as parameterized, it would not necessary be Oracle for all plugins.
There was a problem hiding this comment.
We are having different TestSetupHooks class file for different database plugins. For each database plugin we are using according to the plugin name.
Comment on lines
+439
to
+442
| @After(order = 1, value = "@CONNECTION") | ||
| public static void deleteBQConnection() throws IOException { | ||
| deleteConnection("Oracle", "connection.name"); | ||
| PluginPropertyUtils.removePluginProp("connection.name"); |
There was a problem hiding this comment.
Hence using the database plugin name for different database plugin connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.