Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Duplicate Local Variables in Object Scope" #234

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix "Duplicate Local Variables in Object Scope" #234

merged 1 commit into from
Dec 12, 2024

Conversation

stephenamar-db
Copy link
Collaborator

Fixes #178

JoshRosen
JoshRosen approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@JoshRosen JoshRosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like the implementation here is consistent with the pre-existing logic for detecting duplicate function parameters or duplicate object members.

@stephenamar-db stephenamar-db merged commit 29bcc9a into master Dec 12, 2024
1 check passed
@stephenamar-db stephenamar-db deleted the duplicatelocal branch December 12, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshRosen JoshRosen JoshRosen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sjsonnet accepts duplicate local variables whereas jsonnet doesn't
2 participants
@stephenamar-db @JoshRosen