Impl RleV1Encoder for integer #37
Open
+246
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Dec 31, 2024
|
Looking better now. Some CI failures to address (can ignore the |
suxiaogang223
force-pushed
the
rle_encoding
branch
from
e7b8625 to
f3f724e
Compare
|
@Jefffrey I use a fixed-size array on the stack instead of a heap-allocated Vec now. Perhaps we can use the same approach in the implementation of rle_v2 to avoid memory allocation. https://github.com/datafusion-contrib/orc-rust/blob/main/src/encoding/integer/rle_v2/mod.rs#L217 |
Jefffrey
reviewed
Jan 6, 2025
|
I think it is feasible to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #23
Algorithm adapted from: https://github.com/apache/orc/blob/main/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriter.java