Various refactoring #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting unsigned/signed integer decoder shouldn't need knowledge of a column; only cares about if you need V1 or V2, so refactor to accomodate this. Also simplifies some methods by removing the check for invalid column encoding as this shouldn't be checked at decoder retrieval time anyway.
These are just indirections and serve no purpose as an abstraction, as they don't actually rely on fields from Column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can see the commits for details of the individual refactors which have been grouped into this PR.
Mainly focusing on refactoring stripe/column related code, to ideally aim for: