Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jupyter-kernel-client for the console #32

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Use jupyter-kernel-client for the console #32

merged 1 commit into from
Dec 19, 2024

Conversation

fcollonval
Copy link
Member

Fixes #31

@fcollonval fcollonval added the enhancement New feature or request label Dec 19, 2024
@fcollonval fcollonval requested a review from echarles December 19, 2024 19:48
echarles
echarles approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @fcollonval

@echarles echarles merged commit a9b08f3 into main Dec 19, 2024
5 of 8 checks passed
@echarles echarles deleted the maintenance/oss-client branch December 19, 2024 19:50
echarles pushed a commit that referenced this pull request Dec 19, 2024
@fcollonval @echarles
Use jupyter-kernel-client for the console (#32)
093c327 
Co-authored-by: Frédéric Collonval <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use jupyter-kernel-client in datalayer-core
2 participants
@fcollonval @echarles