Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Project Feedback #208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

flymperopoulos
Copy link
Collaborator

Team,

Great job on the final project 😄 Here are a few comments on your work:

  1. Overall good job on the app. Really fun to play around with. Loved the D3 viz's and the integration of those dashboards with the overall architecture of your app.
  2. One thing I pointed out in the inline comments on my PR pertains to the concept of password encryption and libraries to use to go about that if passport is not the easiest option.
  3. Removing log statements, commenting and documenting your work is something you should definetely work more on...
  4. I made some inline comments on my PR pointing out points where you could break down your code even further. Let me know if you have any questions on this.
  5. Nice use of the stateProvider and in general I was very pleased with your Angular code structure.
  6. Loved the use of sendgrid as the tool for email notification - pretty sweet.

The whole teaching team and I are very proud for what you guys accomplished! Can't wait to see what you end up building next 😄

Filippos

** Don't merge this PR - READ ONLY **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant