feat: convert vals to strings #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dbeatty10
added
the
triage:ready-for-review
|
@dbeatty10 @McKnight-42 Anything I can do to help move this PR forward? |
|
@jimmyshah this is queued up for a member of our engineering team to give it an initial review and provide any relevant feedback. We don't have a set timeline for when they will be able to get to it though. |
|
@dbeatty10 Got it! I didn't know there was a review queue, so that's helpful context. Thank you for the update! |
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
|
Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1001
Problem
There is a bug currently that requires
runtime_configpropertiesvalues to be strings. As a result, integer values need quotes around them in the yml files, which is awkward.With this PR, values are cast as strings, so that the properties can be set in a more expected way.
ADAP-1007
Solution
In
_configure_batch(), I added a check forruntime_config.properties. If they exist, I iterate through the dictionary to cast the values as strings. Changing this part of the code was suggested as an option in #1001.Checklist