Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use execute instead of raw execute to add the query comment as query header #846

Conversation

github-christophe-oudar
Copy link
Contributor

resolves #808

Problem

Intermediate queries involving:

  • get_column_schema_from_query
  • get_columns_in_select_sql

were using raw_execute which doesn't add sql = self._add_query_comment(sql) resulting in queries that miss the header.

Solution

Replace the calls from raw_execute to execute on both functions

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@github-christophe-oudar github-christophe-oudar requested a review from a team as a code owner July 27, 2023 20:44
@cla-bot cla-bot bot added the cla:yes label Jul 27, 2023
@github-christophe-oudar github-christophe-oudar force-pushed the execute-with-header-on-intermediate-queries branch from 0d8e4df to f5d0733 Compare November 4, 2023 19:11
@Kayrnt Kayrnt force-pushed the execute-with-header-on-intermediate-queries branch from f5d0733 to 86652bd Compare November 4, 2023 19:20
@graciegoheen graciegoheen added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Nov 21, 2023
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 20, 2024
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ok to test ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Stale
Projects
None yet
4 participants