Use execute instead of raw execute to add the query comment as query header #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #808
Problem
Intermediate queries involving:
get_column_schema_from_query
get_columns_in_select_sql
were using
raw_execute
which doesn't addsql = self._add_query_comment(sql)
resulting in queries that miss the header.Solution
Replace the calls from
raw_execute
toexecute
on both functionsChecklist