Always emit warning when microbatch models lack any filtered input node #11196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in raises warning The first time the project is run, the appropriate warning about inputs is raised. However, the warning is only being raised when a full parse happens. When partial parsing happens the warning isn't getting raised. In the next commit we'll fix this issue. This commit updates the test to show that the second run (with partial parsing) doesn't raise the update, and thus the test fails.
Of note we are at the point where multiple validations are iterating all of the nodes in a manifest. We should refactor these _soon_ such that we are not iterating over the same list multiple times.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11196 +/- ##
=======================================
Coverage 88.93% 88.94%
=======================================
Files 187 187
Lines 24092 24097 +5
=======================================
+ Hits 21427 21432 +5
Misses 2665 2665
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gshank
changed the title
gshank
approved these changes
Jan 8, 2025
QMalcolm
deleted the
qmalcolm--11159-always-emit-event-time-warning-when-relevant
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
…de (#11196) * Update `TestMicrobatchWithInputWithoutEventTime` to check running again raises warning The first time the project is run, the appropriate warning about inputs is raised. However, the warning is only being raised when a full parse happens. When partial parsing happens the warning isn't getting raised. In the next commit we'll fix this issue. This commit updates the test to show that the second run (with partial parsing) doesn't raise the update, and thus the test fails. * Update manifest loading to _always_ check microbatch model inputs Of note we are at the point where multiple validations are iterating all of the nodes in a manifest. We should refactor these _soon_ such that we are not iterating over the same list multiple times. * Add changie doc (cherry picked from commit 2eb1a5c)
QMalcolm
added a commit
that referenced
this pull request
Jan 8, 2025
…de (#11196) (#11199) * Update `TestMicrobatchWithInputWithoutEventTime` to check running again raises warning The first time the project is run, the appropriate warning about inputs is raised. However, the warning is only being raised when a full parse happens. When partial parsing happens the warning isn't getting raised. In the next commit we'll fix this issue. This commit updates the test to show that the second run (with partial parsing) doesn't raise the update, and thus the test fails. * Update manifest loading to _always_ check microbatch model inputs Of note we are at the point where multiple validations are iterating all of the nodes in a manifest. We should refactor these _soon_ such that we are not iterating over the same list multiple times. * Add changie doc (cherry picked from commit 2eb1a5c) Co-authored-by: Quigley Malcolm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11159
Problem
When doing partial parsing, no warning about microbatch models missing inputs with event time configs are ever fired.
Solution
Ensure we always validate the inputs for microbatch models
Demo
Demo can be found here, or click on the gif.
Checklist