Misc fixes for group info in logging #11218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11218 +/- ##
==========================================
- Coverage 88.92% 86.19% -2.73%
==========================================
Files 187 187
Lines 24041 24049 +8
==========================================
- Hits 21378 20729 -649
- Misses 2663 3320 +657
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aranke
added
the
artifact_minor_upgrade
aranke
commented
Jan 17, 2025
| assert group_data["name"] == "my_group_with_multiple_emails" | ||
| assert group_data["owner"] == { | ||
| "name": "my_name", | ||
| "email": "['[email protected]', '[email protected]']", |
There was a problem hiding this comment.
@rviswanathan-dbt Please check this format, thanks!
There was a problem hiding this comment.
This looks good, just want to confirm what this field looks like in different scenarios:
- single email - "email": "[email protected]"
- multiple emails - email": "['[email protected]', '[email protected]']"
@aranke is my understanding correct?
emmyoop
approved these changes
Jan 17, 2025
Co-authored-by: Emily Rockman <[email protected]>
rviswanathan-dbt
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Misc. fixes for group info in logging:
LogSnapshotResult,LogSeedResult,SkippingDetails,LogSkipBecauseErrorChecklist