Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new dbt invocation command #6822

Merged
merged 16 commits into from
Jan 24, 2025
Merged

add new dbt invocation command #6822

merged 16 commits into from
Jan 24, 2025

Conversation

@mirnawong1 mirnawong1 requested a review from a team as a code owner January 23, 2025 18:35
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 24, 2025 4:02pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Jan 23, 2025
@mirnawong1 mirnawong1 marked this pull request as draft January 23, 2025 18:35
@mirnawong1 mirnawong1 marked this pull request as ready for review January 24, 2025 11:28
@mirnawong1 mirnawong1 requested a review from vfcoelho January 24, 2025 11:28

:::tip

To cancel an active session in the terminal, use the `Ctrl + Z` shortcut.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfcoelho i think it'd be helpful to have a 'get out' tip when the session is hanging -- just confirming this is right? it worked for me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good thinking! We also have another case that the user's session invocation pool is being occupied by the vscode extension. I wonder if there is any way to cancel its invocations if needed. @dichenqiandbt would you know anything about that so we can add to the tips?

</Expandable>

<FAQ path="Troubleshooting/long-sessions-cloud-cli" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

This is a non-blocker but would it be worth making this an expandable or the other expandables, toggles so that they follow the same flow / pattern?

Kind Regards
Natalie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added it as a faq so it can be fetched but maybe we can turn the other expandables in detailsToggle so its consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , going to turn the rest into details toggle so they follow the sme ux

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this PR! It was a great read!
I've approved this for you and left one non-blocking suggestion.

Kind Regards
Natalie

website/docs/reference/commands/invocation.md Outdated Show resolved Hide resolved

:::tip

To cancel an active session in the terminal, use the `Ctrl + Z` shortcut.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good thinking! We also have another case that the user's session invocation pool is being occupied by the vscode extension. I wonder if there is any way to cancel its invocations if needed. @dichenqiandbt would you know anything about that so we can add to the tips?

website/docs/reference/commands/invocation.md Outdated Show resolved Hide resolved
website/docs/reference/dbt-commands.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vfcoelho vfcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc! Just a few nits I added as comments.

@mirnawong1 mirnawong1 enabled auto-merge January 24, 2025 15:58
@mirnawong1 mirnawong1 merged commit 30430a0 into current Jan 24, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the dbt-invocation branch January 24, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[idea] dbt invocation command
3 participants