Skip to content

Commit

Permalink
Update snapshot generation script (#728)
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb authored Aug 17, 2023
1 parent 519b2e7 commit 7a4a17e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changes/unreleased/Under the Hood-20230816-150030.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: Under the Hood
time: 2023-08-16T15:00:30.486465-07:00
custom:
Author: courtneyholcomb
Issue: "728"
7 changes: 5 additions & 2 deletions metricflow/test/generate_snapshots.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class MetricFlowTestCredentialSetForAllEngines(FrozenBaseModel): # noqa: D
snowflake: MetricFlowTestCredentialSet
big_query: MetricFlowTestCredentialSet
databricks: MetricFlowTestCredentialSet
postgres: MetricFlowTestCredentialSet

@property
def as_configurations(self) -> Sequence[MetricFlowTestConfiguration]: # noqa: D
Expand All @@ -89,6 +90,10 @@ def as_configurations(self) -> Sequence[MetricFlowTestConfiguration]: # noqa: D
engine=SqlEngine.DATABRICKS,
credential_set=self.databricks,
),
MetricFlowTestConfiguration(
engine=SqlEngine.POSTGRES,
credential_set=self.postgres,
),
)


Expand Down Expand Up @@ -175,8 +180,6 @@ def run_cli() -> None: # noqa: D
)

for test_configuration in credential_sets.as_configurations:
if test_configuration.engine is SqlEngine.BIGQUERY:
continue
logger.info(
f"Running tests for {test_configuration.engine} with URL: {test_configuration.credential_set.engine_url}"
)
Expand Down

0 comments on commit 7a4a17e

Please sign in to comment.