Allow querying SCDs without metric_time
#1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/scd
branch
from
73787e5 to
952cb2c
Compare
courtneyholcomb
force-pushed
the
court/scd
branch
from
15ea5af to
8b2fe9e
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
tlento
approved these changes
Jan 24, 2025
|
|
||
|
|
||
| @pytest.mark.sql_engine_snapshot | ||
| @pytest.mark.duckdb_only |
There was a problem hiding this comment.
Oh nice! When did we add this?
|
|
||
| @pytest.mark.sql_engine_snapshot | ||
| @pytest.mark.duckdb_only | ||
| def test_scd_with_coarser_grain( # noqa: D103 |
There was a problem hiding this comment.
It might be worth grouping by the listing as well so we can see when the same one is listed multiple times, and then have the docstring explain what's expected. Up to you if you want to do this.
Comment on lines
+6
to
+8
| 2020-01-01T00:00:00 3 2 | ||
| 2020-01-01T00:00:00 4 5 | ||
| 2020-01-01T00:00:00 5 2 |
There was a problem hiding this comment.
Ok. This one is also interesting because the input data is actually truncated by the filter. This is the behavior we're implementing here but I suspect it's worth documenting these cases in some detail when we update the docs page.
plypaul
reviewed
Jan 24, 2025
| @@ -192,19 +189,4 @@ def validate_measure_in_resolution_dag( | |||
| measure_reference: MeasureReference, | |||
| resolution_path: MetricFlowQueryResolutionPath, | |||
| ) -> MetricFlowQueryResolutionIssueSet: | |||
| scd_linkable_elemenent_set_for_measure = self._scd_linkable_element_set_for_measure(measure_reference) | |||
There was a problem hiding this comment.
Seems like we can now remove _scd_linkable_element_set_for_measure and the mention of SCD in the class docstring?
plypaul
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove query validation that requires including
metric_timein the group by if your query includes an SCD. After much product discussion, we've decided this aligns the behavior users expect for SCDs.