add robust errors to gallery #2129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsjoberg
requested changes
Jan 23, 2025
DESCRIPTION
Outdated
| @@ -79,6 +79,7 @@ Suggests: | |||
| parameters (>= 0.20.2), | |||
| parsnip (>= 0.1.7), | |||
| rmarkdown, | |||
| sandwich, | |||
There was a problem hiding this comment.
Since this is an article and not a proper vignette that ships with the package, we don't need to list sandwich under Suggests. Instead we can add it under Config/Needs/website
vignettes/articles/gallery.Rmd
Outdated
| mutate(subject_id = dplyr::row_number(), .by = trt) | ||
| lmod <- lm(response ~ trt + grade, data = dat) | ||
|
|
||
| library(sandwich) |
There was a problem hiding this comment.
can we namespace the sandwich functions instead of attaching, please?
ddsjoberg
approved these changes
Jan 24, 2025
vignettes/articles/gallery.Rmd
Outdated
| tbl_robust | ||
| ``` | ||
|
|
||
| Note that depending on your model, you may also need to set other arguments in `tidy_robust` (e.g. exponentiate). |
There was a problem hiding this comment.
Do we need this comment? Could we not just include tbl_regression(exponentiate=TRUE) instead?
There was a problem hiding this comment.
Great catch! I changed the model to a logit (which is actually anyway better for this outcome), and included the exp argument directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
As discussed in the issue, here's an example of using robust standard errors. I had to add a dependency (under suggests) for sandwich. I hope thats OK. If you happen to know of an existing dependency that contains a function for modifying the vcov matrix, i'm happy to try that instead.
<< Addition of an example on robust standard errors to the gallery vignette >>
If there is an GitHub issue associated with this pull request, please provide link.
closes #2076
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.mdwith the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")usethis::use_spell_check()again