fix: apply fibonacci backoff delay and threshold #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/modules/transaction/sagas.ts
Outdated
| prev = current | ||
| current = next | ||
| } | ||
| return current * INITIAL_BACKOFF_DELAY |
There was a problem hiding this comment.
If we multiply the Fibonacci number with the initial backoff, we'll get double the Fibonacci number. If we want to start with a 2 seconds delay, we could start at the attempt number 2, what do you think about it?
Here we can just multiply the current Fibonacci value by 1000 to have seconds.
Suggested change
| return current * INITIAL_BACKOFF_DELAY | |
| return current * 1000 |
There was a problem hiding this comment.
The idea of that variable was to be able to configure the speed while keeping the fibonacci exponential curve. I changed the name to be more accurate BACKOFF_DELAY_MULTIPLIER and made it faster so it follows the fibonacci sequence instead of the double of the curve.
cazala
force-pushed
the
fix/apply-fibonacci-delay-and-threshold
branch
from
2a56bec to
eaf8a84
Compare
LautaroPetaccio
approved these changes
Jan 14, 2025
|
🎉 This PR is included in version 23.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fibonacci backoff strategy for transaction polling. The changes improve the reliability of transaction status monitoring while reducing unnecessary network calls.
Core Changes (478aeda)
DROPPED_TRANSACTION_THRESHOLDconstant (24 hours)TRANSACTION_FETCH_DELAYtoINITIAL_BACKOFF_DELAYTest Suite Changes (c12b2df)
Technical Details
The fibonacci backoff strategy increases the delay between polling attempts using the fibonacci sequence, starting with an initial delay of 2 seconds. This helps reduce network load while maintaining responsiveness for transaction status updates.