-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: proposal render issue #1368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵️
@@ -75,7 +75,7 @@ export default function ProposalCard({ | |||
<span>{' · '}</span> | |||
</> | |||
)} | |||
<span className="ProposalCard__DetailsItem ProposalCard__DetailsOnlyDesktop"> | |||
<span className="ProposalCard__DetailsItem"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use NotMobile here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class ProposalCard__DetailsOnlyDesktop
didn't exist in a css file 🤷
@@ -7,7 +7,6 @@ import Head from 'decentraland-gatsby/dist/components/Head/Head' | |||
import NotFound from 'decentraland-gatsby/dist/components/Layout/NotFound' | |||
import useAuthContext from 'decentraland-gatsby/dist/context/Auth/useAuthContext' | |||
import usePatchState from 'decentraland-gatsby/dist/hooks/usePatchState' | |||
import { Loader } from 'decentraland-ui/dist/components/Loader/Loader' | |||
import { NotMobile, useMobileMediaQuery } from 'decentraland-ui/dist/components/Media/Media' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If dcl-ui components are not working for us, maybe we should stop using them. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I agree. We should change it in all files. But I wanted to focus on fixing the issue in the proposals page.
No description provided.