Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proposal render issue #1368

Merged
merged 3 commits into from
Oct 26, 2023
Merged

fix: proposal render issue #1368

merged 3 commits into from
Oct 26, 2023

Conversation

andyesp
Copy link
Member

@andyesp andyesp commented Oct 25, 2023

No description provided.

@andyesp andyesp temporarily deployed to governance-pr-1368 October 25, 2023 15:41 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1368 October 25, 2023 17:03 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1368 October 25, 2023 17:23 Inactive
Copy link
Collaborator

@1emu 1emu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️

@@ -75,7 +75,7 @@ export default function ProposalCard({
<span>{' · '}</span>
</>
)}
<span className="ProposalCard__DetailsItem ProposalCard__DetailsOnlyDesktop">
<span className="ProposalCard__DetailsItem">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use NotMobile here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class ProposalCard__DetailsOnlyDesktop didn't exist in a css file 🤷

@@ -7,7 +7,6 @@ import Head from 'decentraland-gatsby/dist/components/Head/Head'
import NotFound from 'decentraland-gatsby/dist/components/Layout/NotFound'
import useAuthContext from 'decentraland-gatsby/dist/context/Auth/useAuthContext'
import usePatchState from 'decentraland-gatsby/dist/hooks/usePatchState'
import { Loader } from 'decentraland-ui/dist/components/Loader/Loader'
import { NotMobile, useMobileMediaQuery } from 'decentraland-ui/dist/components/Media/Media'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If dcl-ui components are not working for us, maybe we should stop using them. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I agree. We should change it in all files. But I wanted to focus on fixing the issue in the proposals page.

@andyesp andyesp merged commit 1cd5c4d into master Oct 26, 2023
1 check passed
@andyesp andyesp deleted the fix/proposals-render-issue branch October 26, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants