fix: Search sorting #1374
Merged
fix: Search sorting #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyesp
reviewed
Oct 27, 2023
andyesp
reviewed
Oct 27, 2023
1emu
reviewed
Oct 27, 2023
andyesp
reviewed
Oct 27, 2023
andyesp
reviewed
Oct 27, 2023
andyesp
reviewed
Oct 30, 2023
andyesp
reviewed
Oct 30, 2023
| } | ||
|
|
||
| export function toSortingOrder<OrElse>(value: string | null | undefined, orElse: () => OrElse) { | ||
| return toCustomType<SortingOrder, OrElse, typeof value>(value, isSortingOrder, orElse) |
There was a problem hiding this comment.
I don't like the orElse callback as I find it confusing to see all those functions returning null/undefined everywhere. I'd change this to a default value argument. But we can discuss this later and change it in another PR.
andyesp
approved these changes
Oct 30, 2023
1emu
approved these changes
Oct 30, 2023
1emu
approved these changes
Oct 31, 2023
andyesp
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1354