fix: Remove service from list of services

decentraland · Nov 12, 2024 · 519a366 · 519a366
1 parent eddfacf
commit 519a366
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/webapp/src/modules/vendor/VendorFactory.ts b/webapp/src/modules/vendor/VendorFactory.ts
@@ -1,6 +1,6 @@
 import { BaseClientConfig } from 'decentraland-dapps/dist/lib/BaseClient'
 import { convertToOutputString } from '../../utils/output'
-import { ContractService, NFTService, OrderService, BidService, AnalyticsService } from './decentraland'
+import { ContractService, NFTService, OrderService, BidService } from './decentraland'
 import { VendorName } from './types'
 
 export class VendorFactory {
@@ -12,8 +12,7 @@ export class VendorFactory {
           new ContractService(),
           new NFTService(config, shouldUseLegacyAPIs),
           new OrderService(shouldUseLegacyAPIs),
-          new BidService(),
-          new AnalyticsService()
+          new BidService()
         )
       default:
         throw new Error(`Invalid vendor "${convertToOutputString(vendor)}"`)
@@ -27,7 +26,6 @@ export class Vendor<V extends VendorName> {
     public contractService: ContractService,
     public nftService: NFTService,
     public orderService: OrderService,
-    public bidService?: BidService,
-    public analyticsService?: AnalyticsService
+    public bidService?: BidService
   ) {}
 }
diff --git a/webapp/src/modules/vendor/decentraland/AnalyticsService.ts b/webapp/src/modules/vendor/decentraland/AnalyticsService.ts
@@ -1,11 +1,10 @@
 import { utils } from 'ethers'
 import { AnalyticsTimeframe } from '../../analytics/types'
-import { AnalyticsService as AnalyticsServiceInterface } from '../services'
 import { TokenConverter } from '../TokenConverter'
 import { AnalyticsAPI } from './analytics/api'
 import { retryParams } from './utils'
 
-export class AnalyticsService implements AnalyticsServiceInterface {
+export class AnalyticsService {
   private tokenConverter: TokenConverter
   private analyticsAPI: AnalyticsAPI
 

diff --git a/webapp/src/modules/vendor/services.ts b/webapp/src/modules/vendor/services.ts
@@ -12,7 +12,6 @@ import {
 } from '@dcl/schemas'
 import { Wallet } from 'decentraland-dapps/dist/modules/wallet/types'
 import { Account } from '../account/types'
-import { AnalyticsTimeframe, AnalyticsVolumeData } from '../analytics/types'
 import { NFT, NFTsFetchParams, NFTsCountParams } from '../nft/types'
 import { OrderResponse } from './decentraland/order/types'
 import { NFTsFetchFilters } from './nft/types'
@@ -24,10 +23,6 @@ export type Contract = Omit<BaseContract, 'category'> & {
   vendor: VendorName | null
 }
 
-export interface AnalyticsService {
-  fetchVolumeData: (timeframe: AnalyticsTimeframe) => Promise<AnalyticsVolumeData>
-}
-
 export interface NFTService<V extends VendorName> {
   fetch: (
     params: NFTsFetchParams,