Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty search catalog #2044

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: empty search catalog #2044

merged 1 commit into from
Oct 30, 2023

Conversation

meelrossi
Copy link
Contributor

  • Fix issue when clearing search input it would not reload the page with all items
  • Fix double call to catalog endpoint when using search dropdown. It was being called once with the previous searchUUID and once with the correct searchUUID

@coveralls
Copy link

Coverage Status

coverage: 40.704%. remained the same when pulling 3365f09 on fix/search into b74d0a3 on master.

Copy link
Contributor

@juanmahidalgo juanmahidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix @meelrossi 👏

@meelrossi meelrossi merged commit 049b7e8 into master Oct 30, 2023
5 checks passed
@meelrossi meelrossi deleted the fix/search branch October 30, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants