Merge pull request #11 from decentraland/update/tween

Update Tween duration to use seconds insted of ms
decentraland · Feb 15, 2024 · bb7f8ca · bb7f8ca
2 parents a16d234 + 8043b92
commit bb7f8ca
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/tween.ts b/src/tween.ts
@@ -26,7 +26,7 @@ function createTweens(targetEngine: IEngine) {
       const tween = Tween.get(entity)
       tweenData.normalizedTime += dt
 
-      if (tweenData.normalizedTime >= (tween.duration / 1000)) {
+      if (tweenData.normalizedTime >= tween.duration) {
         deadTweens.push(entity)
       }
     }
@@ -59,7 +59,7 @@ function createTweens(targetEngine: IEngine) {
       const currentTime = duration === 0 ? 1 : 0
       tweenMap.set(entity, { normalizedTime: currentTime, callback: onFinish })
       Tween.createOrReplace(entity, {
-        duration,
+        duration: duration * 1000,
         easingFunction: getEasingFunctionFromInterpolation(interpolationType),
         currentTime,
         mode: Tween.Mode[mode]({ start: start as any, end: end as any })