Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: friendships #11

Merged
merged 10 commits into from
Apr 24, 2024
Merged

feat: friendships #11

merged 10 commits into from
Apr 24, 2024

Conversation

lauti7
Copy link
Contributor

@lauti7 lauti7 commented Apr 23, 2024

This PR:

  • updates an existing migration and adds a new table migration
  • adds Redis to leverage the Pub/Sub system
  • adds DB queries to handle and manage friendships
  • adds business logic for friendships
  • removes local protocol and uses the .proto from @dcl/protocol

hugoArregui
hugoArregui approved these changes Apr 24, 2024
View reviewed changes
Copy link

@hugoArregui hugoArregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general is ok, I don't fully understand how is redis been used

src/ports/redis.ts Outdated
@@ -0,0 +1,37 @@
import { createClient } from 'redis'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use ports directory anymore, they are called adapters now

@lauti7 lauti7 merged commit caa156d into main Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoArregui hugoArregui hugoArregui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lauti7 @hugoArregui