fix: Check if the notification has a mapped component

decentraland · Sep 5, 2024 · 3950fa0 · 3950fa0
1 parent bd8697c
commit 3950fa0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/components/Notifications/NotificationsFeed.tsx b/src/components/Notifications/NotificationsFeed.tsx
@@ -121,6 +121,11 @@ const NotificationHandler = ({
   renderProfile?: (address: string) => JSX.Element | string | null
 }) => {
   const NotificationComponent = NotificationComponentByType[notification.type]
+
+  if (!NotificationComponent) {
+    return null
+  }
+
   return (
     <NotificationComponent
       notification={notification}

diff --git a/src/components/Notifications/utils.tsx b/src/components/Notifications/utils.tsx
@@ -50,12 +50,14 @@ export function getBGColorByRarity(rarity: Rarity) {
   return Rarity.getGradient(rarity).join()
 }
 
-export type DecentralandNotificationComponentByType<T> = {
-  [k in NotificationType]: T extends DCLNotification
-    ? // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      FunctionComponent<CommonNotificationProps<any>>
-    : never
-}
+export type DecentralandNotificationComponentByType<T> = Partial<
+  {
+    [k in NotificationType]: T extends DCLNotification
+      ? // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        FunctionComponent<CommonNotificationProps<any>>
+      : never
+  }
+>
 
 export const NotificationComponentByType: DecentralandNotificationComponentByType<DCLNotification> =
   {
@@ -101,7 +103,6 @@ export const NotificationComponentByType: DecentralandNotificationComponentByTyp
       CampaignOutOfStockNotification,
     [NotificationType.REWARD_CAMPAIGN_GAS_PRICE_HIGHER_THAN_EXPECTED]:
       CampaignGasPriceHigherThanExpectedNotification,
-    [NotificationType.BADGE_GRANTED]: null,
     [NotificationType.EVENTS_STARTS_SOON]: EventsStartsSoonNotification,
     [NotificationType.EVENTS_STARTED]: EventsStartedNotification,
     [NotificationType.WORLDS_PERMISSION_GRANTED]: