New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ghost shader not working properly #5919

Closed

Kinerius wants to merge 1 commit into dev from fix/ghost-shader

Contributor

Kinerius commented Nov 10, 2023

What does this PR change?

Removed alpha clipping from ghost shader, using just alpha

How to test the changes?

See other players log in
Ghost shader should work properly

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary


          Removed alpha clipping from Ghost Shader

1ddd3d8

Kinerius self-assigned this

Contributor

github-actions bot commented Nov 10, 2023

After the CI passes:

Web

This branch can be previewed at:

Desktop:

If you have the launcher installed (download launcher) you can press open on the following link:

SDK 6/7:

More

Code coverage report: https://renderer-artifacts.decentraland.org/branch-coverage/fix/ghost-shader
Benchmark report: https://renderer-artifacts.decentraland.org/branch-benchmark/fix/ghost-shader/index.html

Kinerius closed this

Kinerius deleted the fix/ghost-shader branch

November 13, 2023 17:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet