fix: sdk7 tween transform parent id overwrite #5981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
pravusjif
requested review from
popuz and
sandrade-dcl
and removed request for
a team
sandrade-dcl
approved these changes
Nov 27, 2023
gonpombo8
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent id contained in the Transform components was getting lost when the component got updated by the Tween System.
Issue: decentraland/sdk#1044
Copilot summary
🤖[deprecated] Generated by Copilot at c31bd80
This pull request refactors the
ECSTweenSystemplugin to use theIDCLEntityinterface instead of the entity id for updating the tween and transform components of the entities. This improves the performance and readability of the code and ensures the consistency of the entity hierarchy. The pull request also updates the corresponding unit test and the assembly definition file.