-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sdk7 raycast-result support for non-sdk7 entity colliders #5986
feat: sdk7 raycast-result support for non-sdk7 entity colliders #5986
Conversation
…en hitting a non-sdk7-entity collider
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
…into feat/sdk7-raycast-result-support-for-sdk6-colliders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🟢 minor suggestion
return null; | ||
|
||
hit = new RaycastHit(); | ||
hit.EntityId = (uint)entity.entityId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be simplified to
hit = new RaycastHit { EntityId = (uint)entity.entityId };
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Reviewed and approved. No mayor issues were found
Mini refactor to allow returning raycast results with partial data when hitting a non-sdk7-entity collider
Issue: decentraland/sdk#1033
Copilot summary
🤖[deprecated] Generated by Copilot at ec7640a
Fix raycast system to detect hits on SDK6 entities in persistent and portable scenes. Add null check and collision layer mask check for hit entities in
ECSRaycastSystem.cs
.QA TEST INSTRUCTIONS
1.mp4
2.mp4
3.mp4