Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show back pending status warning for email subscriptions #5997

Conversation

sandrade-dcl
Copy link
Contributor

@sandrade-dcl sandrade-dcl commented Dec 4, 2023

What does this PR change?

Since we have recovered the double user's action for registering the email, we need to show back the yellow warning message right after we add/modify our email in "Account Settings" -> "Email Notifications".

image

How to test the changes?

  1. Launch the explorer.
  2. Go to Account Settings -> Email Notifications.
  3. Add or modify your email.
  4. Check that the warning message appears.
  5. Go to your email inbox and confirm your email.
  6. Go back to the explorer, go out of the Email Notifications and go back to it.
  7. Check that the warning message doesn't appear because your email is already confirmed.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

🤖[deprecated] Generated by Copilot at b567a17

Added logic to handle email verification and validation status in EmailNotificationsController.cs. This improves the user experience of managing email notifications in the My Account HUD.

@sandrade-dcl sandrade-dcl self-assigned this Dec 4, 2023
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yellow warning message correctly appears immediately after adding or modifying the email in 'Account Settings' -> 'Email Notifications'.
This fix has been verified on both Desktop and Browser.

Screen.Recording.2023-12-04.at.15.05.02.mov

Copy link
Contributor

@LucasLioyQA LucasLioyQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved

Screenshot 2023-12-04 at 15 18 21 Screenshot 2023-12-04 at 15 18 42 Screenshot 2023-12-04 at 15 20 04

@sandrade-dcl sandrade-dcl merged commit 63b9155 into dev Dec 4, 2023
4 checks passed
@sandrade-dcl sandrade-dcl deleted the fix/show-back-pending-status-warning-for-email-subscriptions branch December 4, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants