Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: outfits are not being equipped correctly #6003

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

sandrade-dcl
Copy link
Contributor

@sandrade-dcl sandrade-dcl commented Dec 5, 2023

What does this PR change?

The equipping outfits was not working.

image

How to test the changes?

  1. Launch the explorer
  2. Go to the backpack
  3. Try to equip a saved outfit
  4. Check that it works correctly
  5. Check that everything else related to the Backpack is working as expected

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

🤖[deprecated] Generated by Copilot at f9a309e

Shortened wearable URNs in BackpackEditorHUDController.cs. This improves the performance and readability of the wearable loading and equipping code.

@sandrade-dcl sandrade-dcl self-assigned this Dec 5, 2023
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Fix reviewed by QA and working as expected:

05.12.2023_16.49.15_REC.mp4

Copy link
Contributor

@LucasLioyQA LucasLioyQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved

Screenshot 2023-12-05 at 14 18 58 Screenshot 2023-12-05 at 14 35 00

Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Review completed and fix verified. Backpack and outfits are working as expected within the different locations, worlds and events.

Screen.Recording.2023-12-05.at.17.08.06.mp4

@sandrade-dcl sandrade-dcl added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 3c77ad9 Dec 6, 2023
1 check passed
@sandrade-dcl sandrade-dcl deleted the hotfix/outfits-do-not-equip-correctly branch December 6, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants