hotfix: bump eth-connect dependency version #6005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: sync main to dev
show back pending status warning for email subscriptions
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
sandrade-dcl
changed the title
LucasLioyQA
approved these changes
Dec 5, 2023
davidejensen
approved these changes
Dec 5, 2023
.../Assets/Scripts/MainScripts/DCL/Controllers/HUD/MyAccountHUD/EmailNotificationsController.cs
Show resolved
Hide resolved
Ludmilafantaniella
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Bump
eth-connectversion to include fix that was causing loging in in firefox not to work. We are checking that the error key is not present or is undefined to make a response validHow to test the changes?
Log in using firefox to https://play.decentraland.org/?explorer-branch=fix/bump-eth-connect-version
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖[deprecated] Generated by Copilot at a5107af
This pull request updates the
eth-connectdependency in thebrowser-interfacepackage to the latest version. This allows the package to use the latest features and bug fixes of the library for interacting with Ethereum smart contracts.