fix: sdk7 smart wearable restricted actions call from ui #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
pravusjif
changed the title
pravusjif
requested review from
davidejensen,
Kinerius and
a team
and removed request for
a team
anicalbano
approved these changes
Dec 8, 2023
davidejensen
approved these changes
Dec 8, 2023
pravusjif
deleted the
fix/sdk7-smart-wearable-restricted-actions-from-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unneeded scene tick check for allowing a restricted action to be called from ui.
The bug was introduced while fixing other stuff at #5538.
Fixes decentraland/sdk#1026.
I tested that the restricted actions functionality still works on regular sdk7 scenes with or without UI, and now it works fine for smart wearables with or without UI.
Copilot summary
🤖[deprecated] Generated by Copilot at d331c82
This pull request removes the
EnableRestrictedActionTickfield and its related logic from theInternalEngineInfoECS component model and theECSInputSenderSystemclass, as well as the corresponding tests. This field was used to control the restricted actions in edit mode, but this logic was moved to the kernel side. The pull request also simplifies the condition for checking the edit mode in theSceneStateHandlerclass, using only theSceneTickfield.