Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdk7 SBC basic check order #6014

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: sdk7 SBC basic check order #6014

merged 1 commit into from
Dec 8, 2023

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Dec 8, 2023

Corrected entity transformations Scene Bounds Checker check order.

Currently SDK7's SBC doesn't have test coverage at all, I'll add tests in another PR.


Copilot summary

🤖[deprecated] Generated by Copilot at def4322

Improve performance and clarity of ECSTransformHandler component update logic. Refactor OnComponentModelUpdated method to avoid redundant operations and simplify reparenting cases.


Test Instructions

  1. Enter the snowball fight scene at https://play.decentraland.org/?explorer-branch=fix/sdk7-sbc-basic-check&position=104,51
  2. Confirm that if you leave the scene, the UI disappears
  3. Confirm that from inside the scene if you shoot a snowball towards outside the scene limits, the snowball disappears

@pravusjif pravusjif self-assigned this Dec 8, 2023
@pravusjif pravusjif marked this pull request as ready for review December 8, 2023 12:16
@pravusjif pravusjif requested a review from a team as a code owner December 8, 2023 12:16
@github-actions github-actions bot requested a review from LucasLioyQA December 8, 2023 12:16
@pravusjif pravusjif removed the request for review from a team December 8, 2023 12:17
@pravusjif pravusjif removed the request for review from davidejensen December 8, 2023 13:01
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Reviewed and approved by QA

08.12.2023_10.05.48_REC.mp4

@pravusjif pravusjif merged commit d66b322 into dev Dec 8, 2023
5 checks passed
@pravusjif pravusjif deleted the fix/sdk7-sbc-basic-check branch December 8, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants