Release: 12182023 #6023
Merged
Release: 12182023 #6023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: sync main to dev
expose comms message size by scene id and type
added missing variable reset on cleanup
* Added needed OnTransformChanged event call on sdk7 Transform handler and Tween systems, so that the AvatarShape can reacto to the transform modifications and interpolate accordingly. * Removed in modifier in some OnTransformChanged() methods
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
github-actions
bot
requested review from
Ludmilafantaniella and
sandrade-dcl
Ludmilafantaniella
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
...
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖[deprecated] Generated by Copilot at aec1d03
This pull request introduces some changes to improve the comms performance metrics and the avatar transform handling. It adds some metrics to track the comms messages sent by scene and type, and cleans up some obsolete code in the
LivekitAdaptermodule. It also simplifies the signature and invocation of theOnTransformChangeevent of theIDCLEntityinterface and its implementations, and fixes some bugs and typos in theAvatarShapeandAvatarMovementControllerclasses.